-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page List: Added color support #66430
Page List: Added color support #66430
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @benazeer-ben! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @benazeer-ben 👍
This is working as advertised.
✅ Global Styles apply correctly in the editor and the frontend
✅ Block support styles override global styles in both editor and frontend
I see you chose to explicitly omit text
color support. This might actually be good to add too.
If a link color hasn't been set, applying a text color will automatically set the matching link color. This would allow the page list's bullets to be updated to match link color or differ as the theme author or use might wish.
What do you think?
Without Text Support | With Text Support |
---|---|
Thanks for the suggestion @aaronrobertshaw Yes, you are right. If the text support added then we can use it as optional if we need. Otherwise we can just keep the link colour. I have added text support in the recent commit. |
adding default controls Co-authored-by: Aaron Robertshaw <[email protected]>
@aaronrobertshaw Please let me know if it need more tweaks on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @benazeer-ben ✨
✅ Global styles apply correctly on frontend and in editor
✅ Block support styles override global styles appropriately
✅ Default controls exposed follow convention for color supports
Note: For anyone else testing, there's a known issue where a gradient global style would override block instance's background color. That's due to the use of background
vs background-color
in those styles and isn't introduced here.
@benazeer-ben Could you Please rebase this PR? |
@shail-mehta Thanks for looking into this. This PR has been rebased with the latest trunk branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ry/interactivity-lazy-hydration * 'trunk' of https://github.com/WordPress/gutenberg: (143 commits) Update: Bundle upload media. (#68522) Add: Media field changing ui to Dataviews and content preview field to posts and pages (#67278) Bump the react-native group with 2 updates (#68095) Check Storybook build on CI for PRs (#68466) Bump the github-actions group across 1 directory with 2 updates (#68436) Classic theme preview: remove admin-bar class name (#68519) Remove geriux as code owner (#68523) Post Featured Image: Adds control to clear the the overlay color (#68525) Components: Standardize reduced motion handling using media queries (#68421) Upgrade Playwright to v1.49 (#68504) Document Outline: Use block client ID as unique 'key' (#68502) Storybook: Add UnitControl story (#67346) Details: Add allowedBlocks and TemplateLock attributes (#68489) Post Comment Link: Show Border Control By Default (#68506) Query Total: Show Border Controls By Default (#68507) RSS: Added Colour support (#66419) Refactor: Separate input form styles to a dedicated stylesheet (#68501) Code quality: Fix typos (#67304) Page List: Added color support (#66430) Fix flaky DataViews list arraow nav e2e tests (#68503) ...
What?
Add color support to the Page List block.
Part of : #43245
Why?
Page List block is missing color support.
How?
Adds the color support via block.json
Testing Instructions
Screenshots or screencast
Backend:
Frontend: