Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unused test code on tools panel. #67589

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions packages/components/src/tools-panel/test/index.tsx
Original file line number Diff line number Diff line change
@@ -154,7 +154,6 @@ const renderWrappedItemInPanel = () => {
const renderPanel = () => {
return render(
<ToolsPanel { ...defaultProps }>
{ false && <div>Hidden</div> }
<ToolsPanelItem { ...controlProps }>
<div>Example control</div>
</ToolsPanelItem>
@@ -236,22 +235,6 @@ describe( 'ToolsPanel', () => {
it( 'should not render panel menu when there are no panel items', () => {
render(
<ToolsPanel { ...defaultProps }>
{ false && (
<ToolsPanelItem
label="Not rendered 1"
hasValue={ () => false }
>
Should not show
</ToolsPanelItem>
) }
{ false && (
<ToolsPanelItem
label="Not rendered 2"
hasValue={ () => false }
>
Not shown either
</ToolsPanelItem>
) }
<span>Visible but insignificant</span>
</ToolsPanel>
);

Unchanged files with check annotations Beta

// Wait for the canvas loader to appear first, so that the locator that
// waits for the hidden state doesn't resolve prematurely.
await canvasLoader.waitFor( { state: 'visible' } );

Check failure on line 57 in packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts

GitHub Actions / Playwright - 8

[firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@firefox

1) [firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@Firefox, @WebKit) › submenu click on the arrow interactions TimeoutError: locator.waitFor: Timeout 10000ms exceeded. Call log: - waiting for locator('.edit-site-canvas-loader, .edit-site-canvas-spinner') to be visible at ../../../packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57 55 | // Wait for the canvas loader to appear first, so that the locator that 56 | // waits for the hidden state doesn't resolve prematurely. > 57 | await canvasLoader.waitFor( { state: 'visible' } ); | ^ 58 | await canvasLoader.waitFor( { 59 | state: 'hidden', 60 | // Bigger timeout is needed for larger entities, like the Large Post at Admin.visitSiteEditor (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57:22) at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:353:4

Check failure on line 57 in packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts

GitHub Actions / Playwright - 8

[firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@firefox

1) [firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@Firefox, @WebKit) › submenu click on the arrow interactions Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.waitFor: Timeout 10000ms exceeded. Call log: - waiting for locator('.edit-site-canvas-loader, .edit-site-canvas-spinner') to be visible at ../../../packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57 55 | // Wait for the canvas loader to appear first, so that the locator that 56 | // waits for the hidden state doesn't resolve prematurely. > 57 | await canvasLoader.waitFor( { state: 'visible' } ); | ^ 58 | await canvasLoader.waitFor( { 59 | state: 'hidden', 60 | // Bigger timeout is needed for larger entities, like the Large Post at Admin.visitSiteEditor (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57:22) at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:353:4
await canvasLoader.waitFor( {
state: 'hidden',
// Bigger timeout is needed for larger entities, like the Large Post