Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-content block header color support #67783

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Dec 10, 2024

What?

Similar #49131

Related:

Tracking: Addressing Design Tooling Consistency #43241
Tracking: Color Design Tools Consistency #43245

Why?

Post-content can change the color for each header in theme.json.
I think post-content header color should be supported.

How?

Testing Instructions

  1. Open site editor
  2. Edit post content block
  3. You can edit post content heading color

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before post-content

Tag
[Type] Enhancement
[Feature] Design Tools
[Block] Post Content

Copy link

github-actions bot commented Dec 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shimotmk
Copy link
Contributor Author

@aaronrobertshaw
Can you please leave a review?

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Content Affects the Post Content Block labels Jan 6, 2025
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shimotmk 👍

✅ Heading color controls appear for the Post Content block
✅ Global Styles for Post Content heading colors apply in editor and frontend
✅ Block instance styles on heading blocks override Post Content heading colors

LGTM 🚢

@shimotmk
Copy link
Contributor Author

@aaronrobertshaw
Thanks for your review! Is there anything else I need to do?

@aaronrobertshaw aaronrobertshaw merged commit 064b879 into WordPress:trunk Jan 17, 2025
66 of 72 checks passed
@aaronrobertshaw
Copy link
Contributor

There was a failed e2e test around labels. I've re-run that and taken the liberty to merge this for you.

@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 17, 2025
shimotmk added a commit to shimotmk/gutenberg that referenced this pull request Jan 17, 2025
@shimotmk shimotmk deleted the post-content-add-heading-color-support branch January 17, 2025 08:34
@shimotmk
Copy link
Contributor Author

Thank you for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Content Affects the Post Content Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants