Remove auto-focusing appender onSelectOrClose #67851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: -20 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5f0dbf0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12285051929
|
|
Thanks for the fix! As mentioned in the comment, will the "focus appender on Esc" behavior be addressed in a follow-up? Either way, it might be worth backporting this PR to WP 6.7.2. |
It seems like the code being removed here only fixed focusing the appender when closing the inserter from the social icons appender. Reaching the appenders and using them with a keyboard is very difficult or impossible. I can only reach the default in canvas appender if I press Enter to create an empty block, then Shift + Tab to reach it. The focus handling on it is fine though (Enter moves focus into the quick inserter, Escape re-focuses the button). I know I've looked at this before but not made any progress. For example, I believe this line for figuring out where to send focus after closing the navigation link popover would have gone to the appender, but there isn't a way (currently) to send focus back to it. So, I added a fallback to focus something close by. I'd love to have a way to always send focus back to the appender. I think it may be a larger-than-it-should-be project, unfortunately :/ |
|
Closing in favor of #68060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out as alternative to #67838
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast