Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Submenu Block: Add example preview #68378

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Navigation Submenu Block: Add example preview #68378

merged 2 commits into from
Jan 27, 2025

Conversation

himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Dec 30, 2024 •
edited
Loading

Part of: #64707

What?

Add translatable example preview text in the Navigation Submenu block.

Testing Instructions

  • Navigate to a page or post editor
  • Click the inserter button (+)
  • Search for "Navigation Submenu"
  • Verify the block preview appears in the inserter with translatable text

Screenshot

image

@himanshupathak95 himanshupathak95 marked this pull request as ready for review December 30, 2024 06:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement. [Feature] Style Book labels Jan 13, 2025
@carolinan carolinan enabled auto-merge (squash) January 24, 2025 05:08
auto-merge was automatically disabled January 24, 2025 05:49

Head branch was pushed to by a user without write access

@himanshupathak95 himanshupathak95 force-pushed the add/navigation-submenu-block-example branch from 881e055 to 17f41c1 Compare January 24, 2025 05:49
@himanshupathak95
Copy link
Contributor Author

The E2E Playwright - 2 test is passing locally but failing here, rebasing again to re-run the jobs.

@himanshupathak95 himanshupathak95 force-pushed the add/navigation-submenu-block-example branch from 17f41c1 to d8d0eea Compare January 24, 2025 06:35
@himanshupathak95 himanshupathak95 force-pushed the add/navigation-submenu-block-example branch from d8d0eea to ac263ac Compare January 27, 2025 04:53
@himanshupathak95
Copy link
Contributor Author

Hi @carolinan, Thanks for approving the PR.

The tests are now passing since they were fixed by #68872. This PR is now ready to be shipped 🚀

@carolinan carolinan merged commit b984ec9 into WordPress:trunk Jan 27, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation [Feature] Style Book [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.2
Development

Successfully merging this pull request may close these issues.
3 participants
@himanshupathak95 @carolinan @Mamaduka