Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Template: Add Layout Support #68486

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Jan 4, 2025

What?

Added Layout support to the Comment Template Block.

Part of : #43248

Why?

The block was missing Layout Support Features.

Testing Instructions

  • Test the Comment Template block in both the block editor and site editor.
  • Confirm that the layout setting work correctly, and display correctly on the front.
    -In the Site Editor, Open or Create the template for single posts. Add a Comment Template block & Test the layout setting work correctly.

Screenshots or Screencast

comment-template-layout-support.mp4

@shail-mehta shail-mehta added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Comment Template Affects the Comment Template Block [Feature] Layout Layout block support, its UI controls, and style output. labels Jan 4, 2025
@shail-mehta shail-mehta self-assigned this Jan 4, 2025
@shail-mehta shail-mehta added the [Type] Enhancement A suggestion for improvement. label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Flaky tests detected in 5cb3592.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12608328204
📝 Reported issues:

@shail-mehta shail-mehta marked this pull request as ready for review January 4, 2025 07:18
Copy link

github-actions bot commented Jan 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronrobertshaw
Copy link
Contributor

Thanks for putting the PR together @shail-mehta 👍

I've removed myself from the reviewers as I don't have the bandwidth for reviews in the near future.

To help those who can review, would you mind expanding on the test instructions? It helps to assume people coming to your PR have no context.

For example:

Also Check With layout width in Layout Settings
Check Settings in Editor and Frontend Side

Check what? What should be changed/set, and what's the expected outcome?

@aaronrobertshaw aaronrobertshaw removed their request for review January 6, 2025 03:56
@ramonjd ramonjd removed their request for review January 6, 2025 04:26
@shail-mehta
Copy link
Member Author

Thanks for the feedback. I will work on this.

@shail-mehta
Copy link
Member Author

Updated Testing Instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Template Affects the Comment Template Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Layout Layout block support, its UI controls, and style output. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants