Core Data: Check post-type support before requesting autosaves #68680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
fix/core-data-get-autosaves-resolver
branch
2 times, most recently
from
f1d7623 to
b4b176d
Compare
|
Size Change: +13 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/core-data-get-autosaves-resolver
branch
from
b4b176d to
e71ea6a
Compare
|
Flaky tests detected in e71ea6a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12785860317
|
|
Based on discussion at WordPress/wordpress-develop#6035 we should also update this hardcoded check in gutenberg/packages/editor/src/store/selectors.js Lines 389 to 400 in 5a5455c As well as in gutenberg/packages/editor/src/store/selectors.js Lines 612 to 617 in 5a5455c |
|
Yes, I'm aware of those conditions. It needs to be handled separately after WordPress/wordpress-develop#7272 is merged. Both template and template parts support autosaves, but they are not working correctly. |
|
Looks like that one is ready to be committed, so I can do that. But I guess then we'll need to wait a bit until GB can use it? |
swissspidy
approved these changes
Jan 15, 2025
That or try to shim it the plugin. |
|
I think waiting is fine 👍 |
|
Thanks, @swissspidy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
getAutosavescore data resolver to check if the post type supports autosaves before requesting data.Why?
Starting from WordPress 6.6, individual post-types can disable autosaves. The extra checks prevent unnecessary requests and 404 errors.
Testing Instructions
wp.data.select( 'core' ).getAutosave( 'page', pageId );Testing Instructions for Keyboard
Same.
Screenshots or screencast