Fix: Add rel="tag" to individual anchor links in editor markup of the post terms block
#68722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he post terms block
fabiankaegy
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +8 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 17, 2025
fabiankaegy
deleted the
fix/ensure-post-term-block-markup-matches-frontend-markup
branch
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
…he post terms block (WordPress#68722) Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a really minor change I noticed whilst working on something else, so I quickly created this PR without adding an issue first. Happy to create one if this is more controversial
What?
Adds the
rel="tag"attribute to theaelements of thepost-termsblock in the editorWhy?
Because the frontend markup renders them that way. On the server we use the
get_the_term_listfunction to produce the markup which includes therel="tag"attribute.gutenberg/packages/block-library/src/post-terms/index.php
Lines 49 to 55 in 5688333
https://github.com/WordPress/wordpress-develop/blob/d2a7bee9a6201f0276492ff29afd8c509480d266/src/wp-includes/category-template.php#L1356
How?
Adding the attribute in the edit.js file
Testing Instructions
rel="tag"attribute present