Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Styles: Update z-index for snackbars to ensure proper layering with modals #68730

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Jan 17, 2025

What, Why & How?

closes: #68728

This PR addresses the bug where the Snackbar gets displayed below the Dialog by incrementing the z-index.

Testing Instructions

  1. Navigate to the post edit screen.
  2. Open the Block Inserter.
  3. Navigate to the Patterns tab and open the Explore all patterns dialog.
  4. Try selecting a Pattern from the Dialog.
  5. Confirm that the snackbar now gets rendered above the dialog.

Screencast

PR.mov

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review January 17, 2025 05:45
Copy link

github-actions bot commented Jan 17, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Jan 17, 2025
@Mamaduka
Copy link
Member

A small unrelated suggestion, @yogeshbhutkar! You might want to place an issue reference just under the first heading; this makes it easier to spot the associated issue.

@yogeshbhutkar
Copy link
Contributor Author

Thanks for the suggestion @Mamaduka. Updated the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbar: Display Snackbar on top of Modal Screen Overlay
2 participants