Fix: Linked featured image block cannot be selected correctly #68775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -43 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
t-hamano
added
[Type] Bug
|
With this change, the deletion works if I select the block with the mouse. But when I navigate up and down the content using the arrow keys, the featured image block has two stops, compared to on trunk, where there is one stop. If I start above the block and press arrow down key, the outline shows and the deletion works. Windows 11, Chrome Version 132.0.6834.84. |
|
Thanks for the review!
This seems to be happening with the Site Logo blocks, Image block as well. I recall having a discussion about this in the past. I think adding See here for more details. |
|
Shame, I don't like the idea of fixing an issue by making something else worse, but it is much more important that the block can be deleted. |
carolinan
approved these changes
Jan 21, 2025
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
…ess#68775) Co-authored-by: t-hamano <[email protected]> Co-authored-by: carolinan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68774
What?
This PR will allow the linked Featured Image block to be selected correctly.
Why?
The
aelement appears unclickable at first glance becausedisabledClickPropshas been applied to it. However:onClickevent is prevented viapreventDefault, the click event itself will still occur.aria-disabledis an ARIA attribute, it doesn't actually disable the element.Therefore, when you select a block, the a element inside it will be selected instead of the block, so the outline will not be displayed and the delete key will not work.
How?
I used
pointer-events:noneas a simpler approach.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
b48b3d5793814ca554073a7a7836fb36.mp4