Gallery: Remove unused inline menu styles #68776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Code Quality
t-hamano
reviewed
Jan 21, 2025
himanshupathak95
changed the title
|
Thanks, @t-hamano for the review. I have removed the |
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
* Gallery: Remove unused inline menu transition * Base Styles: Remove unused styles entirely Co-authored-by: himanshupathak95 <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #68282
Follow-up: #68315 (comment)
What?
Remove unused CSS transition used for the gallery block's inline menu that is no longer being used.
Why?
The
.block-library-gallery-item__inline-menuelement was previously used for gallery controls but has since been removed/replaced. This transition is now unused, making them technical debt that should be cleaned up.This PR follows up on the discussion from #68315 where it was identified that these styles could be safely removed.
Testing Instructions