-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Searching by Multiple Option Properties to ComboboxControl
#68829
base: trunk
Are you sure you want to change the base?
Add Support for Searching by Multiple Option Properties to ComboboxControl
#68829
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -89,9 +92,17 @@ Function called when the control's search input value changes. The argument cont | |||
- Type: `( value: string ) => void` | |||
- Required: No | |||
|
|||
#### filterProperties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual component uses filterFields
and not filterProperties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I have updated it.
@@ -40,10 +40,13 @@ function MyComboboxControl() { | |||
value={ fontSize } | |||
onChange={ setFontSize } | |||
options={ filteredOptions } | |||
filterProperties={ ['value', 'label'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual component uses filterFields
and not filterProperties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I have updated it.
Why?
This PR is intended to solve issue mentioned here: #68760
How?
Testing Instructions
ComboboxControl
component.Screenshots or screencast
ComboboxControl.Screencast.mov