Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added discord in social links. #68848

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Added discord in social links. #68848

merged 4 commits into from
Feb 4, 2025

Conversation

Gulamdastgir-Momin
Copy link
Contributor

@Gulamdastgir-Momin Gulamdastgir-Momin commented Jan 23, 2025 •
edited
Loading

What?

FIxes: #35487

Adds Social Link variation for Discord.

How?

Added discord.js to block-library/icons to add the official svg. Added a line for exporting the icon. Added Discord to the list of services so it will use the correct block variation.

PS: This PR was closed, so I created a new PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Gulamdastgir-Momin <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mrfoxtalbot <[email protected]>
Co-authored-by: donalirl <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Gulamdastgir-Momin! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 23, 2025
@carolinan carolinan added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Jan 23, 2025
t-hamano
t-hamano reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The code looks good overall, but the icon itself could be improved a bit. The current icon is slightly off-center:

discord

Additionally, it would be good to make the path exactly 20px wide, like the other icons.

I've tried adjusting the icon, but it didn't work. I'd be happy if someone from the @WordPress/gutenberg-design could provide the icon 🙏

test/integration/fixtures/blocks/core__separator-color.json Outdated Show resolved Hide resolved
test/integration/fixtures/blocks/core__separator-custom-color.json Outdated Show resolved Hide resolved
@t-hamano t-hamano mentioned this pull request Jan 31, 2025
Merged
@Gulamdastgir-Momin
Copy link
Contributor Author

I wonder why these unit test cases are failing 🤔

@t-hamano
Copy link
Contributor

t-hamano commented Feb 3, 2025

The reason is that the following two files have been deleted in this PR. These two files need to be restored:

  • test/integration/fixtures/blocks/core__separator-color.json
  • test/integration/fixtures/blocks/core__separator-custom-color.json

t-hamano
t-hamano approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WordPress/gutenberg-design Maybe I'm being a bit overly sensitive, but if there's room for improvement in the icon and you can provide an SVG, I'd be happy to follow up. For now, it looks good compared to the other icons, so I'd like to merge it.

image

@Gulamdastgir-Momin
Copy link
Contributor Author

Thanks, @t-hamano, for your approval and guidance. Really appreciated!

@t-hamano t-hamano merged commit edbd360 into WordPress:trunk Feb 4, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.3 milestone Feb 4, 2025
@Gulamdastgir-Momin Gulamdastgir-Momin deleted the fix/35487 branch February 4, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.3
Development

Successfully merging this pull request may close these issues.

Social Icons Block: Add Discord to Supported Icons
3 participants
@Gulamdastgir-Momin @t-hamano @carolinan