Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds IMDB and Letterboxd icons to the Social Icon Block #69041

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Feb 5, 2025

Closes: #44789

What?

This PR adds missing IMDB and Letterboxd icons to the Social Icon Block in Gutenberg.

Why?

The Social Icon Block currently does not support IMDB and Letterboxd, making it difficult for users to link to their profiles on these movie-related platforms. Adding these icons improves the block’s functionality and consistency with other supported social networks.

How?

  • Implemented the IMDB icon (imdb.js) using an optimized SVG.
  • Implemented the Letterboxd icon (letterboxd.js) following the existing icon structure.
  • Registered both icons within the @wordpress/icons package.
  • Updated the Social Link Block to include these services.

Testing Instructions

  1. Open the editor and create a new post/page
  2. Add a Social Icons block
  3. Click the "+" button to add a new social link
  4. Search for "IMDB" and "Letterboxd" in the icon picker
  5. Verify the icon appears and matches the design of other social icons
  6. Add your Social profile URLs
  7. Verify the link works correctly in both editor and preview

Screenshots or screencast

IMDB.and.Letterboxd.Screencast.mov

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Feb 5, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Feb 5, 2025

Related #39609 (comment).

@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review February 5, 2025 10:04
Copy link

github-actions bot commented Feb 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jlavoie13, @janmckell.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jlavoie13, janmckell.

Co-authored-by: dhruvikpatel18 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: kathrynwp <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Icon Block missing Movie Services' icons
2 participants