Account for $meta arg in wp_prepare_attachment_for_js not being an array #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
approved these changes
Dec 18, 2024
|
I'm surprised that zepeviktor/phpstan-wordpress didn't catch this issue with static analysis. It looks like there is an open issue for it: szepeviktor/phpstan-wordpress#106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1755
This is a follow-up to #1719.
Relevant technical choices
The
dominant_color_prepare_attachment_for_js()function depends on there being metadata associated with an attachment, since this metadata is where the dominant color information comes from. In addition to allowing$metato be passed asfalseinstead of anarray(which fixes the fatal error), if it is passed asfalsethen the function now short-circuits since there is nothing for it to do.