Show check name in results

[ernilambar]

Related to #329

wp plugin check pc-sample --fields=line,column,type,code,message,check

Sample output:

[ernilambar]

Looks like PHPUnit tests also need to be adjusted with new check value. I will update those after review.

[ernilambar]

cc: @swissspidy @felixarntz @mukeshpanchal27

[swissspidy]

This is an alternative to #376, correct?

[ernilambar]

This is an alternative to #376, correct?

Yes.

[mukeshpanchal27]

Thanks @ernilambar for the PR! Left some feedback and questions for consideration.

[ernilambar]

PR updated.

[swissspidy]

If we display the check name/slug in the results like this, we need to be certain it‘s correct and matches the slug used in Default_Check_Repository. This way users can easily exclude the check next time around.

But what if someone uses the wp_plugin_check_checks filter to add their custom check where this might not be the case (i.e class name differe heavily from the array key)?

IMHO the current solution is not robust enough for this case.

[ernilambar]

What if validate slug and class name in function register_check( $slug, Check $check ). If the slug and class name does not follow the standard, exception is thrown right away while registering.

Another alternative:
In the filter wp_plugin_check_checks rather than accepting slug=>Class_Name, we accept class name only. And our code will generate slug accordingly. This way there will be no mismatched slug and class name.

[ernilambar]

Closing. We need to explore more robust approach.