This repository has been archived by the owner on Dec 1, 2019. It is now read-only.
Improving floated content layout in nested groups. #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbelanger79
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
This looks good to me, but I definitely want @pattonwebz to test it as well.
Merged
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the inconsistencies between the editor and the front end after merging #701.
It allows left/right floated images to look more like what appears in the editor, although it isn’t a perfect 100% match yet. On the frontend, Twenty Twenty resizes the images to make them fit within the layout properly. The editor’s flexible image widths UI, prevent is from replicating the same in the editor. But despite this, the left/right float settings are still respected in both the frontend and backend and so we can iterate on getting an exact 1:1 version later.