Updates to the wporg-events-2023 theme. #1118
Conversation
StevenDufresne
changed the title
public_html/wp-content/themes/wporg-events-2023/patterns/home-page-callout.php
Outdated
Show resolved
Hide resolved
public_html/wp-content/themes/wporg-events-2023/patterns/cover.php
Outdated
Show resolved
Hide resolved
StevenDufresne
force-pushed
the
add/fix-styles
branch
from
feaee2c to
849c4d1
Compare
| <!-- wp:site-title {"level":0,"fontSize":"small"} /--> | ||
|
|
||
| <!-- wp:navigation {"icon":"menu","overlayBackgroundColor":"charcoal-2","overlayTextColor":"white","layout":{"type":"flex","orientation":"horizontal"},"fontSize":"small","menuSlug":"local-navigation"} /--> | ||
| <!-- wp:navigation {"ref":128,"icon":"menu","overlayBackgroundColor":"charcoal-2","overlayTextColor":"white","layout":{"type":"flex","orientation":"horizontal"},"fontSize":"small","menuSlug":"local-navigation"} /--> |
There was a problem hiding this comment.
This breaks the menu in my env. I don't think we need it since we have menuSlug, which creates it dynamically via add_site_navigation_menus(). I'll remove it, but LMK if you think it should come back
|
The map error in your screenshot may just be caused by |
|
|
||
| <!-- wp:column {"verticalAlignment":"top","width":"50%"} --> | ||
| <div class="wp-block-column is-vertically-aligned-top" style="flex-basis:50%"><!-- wp:jetpack/tiled-gallery {"columnWidths":[["65.48121","34.51879"]],"ids":[79,85,82],"style":{"layout":{"selfStretch":"fixed","flexSize":"50%"}}} --> | ||
| <div class="wp-block-jetpack-tiled-gallery aligncenter is-style-rectangular"><div class="tiled-gallery__gallery"><div class="tiled-gallery__row"><div class="tiled-gallery__col" style="flex-basis:65.48121%"><figure class="tiled-gallery__item"><img alt="" data-height="272" data-url="https://events.wordpress.test/wp-content/themes/wporg-events-2023/images/contributors-rectangle1.png" data-width="615" src="https://events.wordpress.test/wp-content/themes/wporg-events-2023/images/contributors-rectangle1.png" data-amp-layout="responsive"/></figure></div></div><div class="tiled-gallery__row"><div class="tiled-gallery__col"><figure class="tiled-gallery__item"><img alt="" data-height="272" data-url="https://events.wordpress.test/wp-content/themes/wporg-events-2023/images/contributors-square1.png" data-width="298" src="https://events.wordpress.test/wp-content/themes/wporg-events-2023/images/contributors-square1.png" data-amp-layout="responsive"/></figure></div><div class="tiled-gallery__col"><figure class="tiled-gallery__item"><img alt="" data-height="272" data-url="https://events.wordpress.test/wp-content/themes/wporg-events-2023/images/contributors-square2.png" data-width="297" src="https://events.wordpress.test/wp-content/themes/wporg-events-2023/images/contributors-square2.png" data-amp-layout="responsive"/></figure></div></div></div></div> |
There was a problem hiding this comment.
It looks like copy/pasting from the editor overwrote the inclusion of the front-contributors-meet-gallery.php pattern. I'd set that up in order to generate the URLs dynamically instead of hardcoding local env URLs like this.
I'll fix it in the next PR, but LMK if you have any ideas on how to structure things better so that we don't accidentally do stuff like this. I'm still trying to find a good editor -> code workflow, so I may not have set it up in the best way.
One nice thing about using template parts is that the editor shows them as a part, so it's more obvious that you should just copy/paste that section into a specific file. For patterns it just says "Group" and you have to already know that it's part of a pattern :(
Implements styles for events.wordpress.org.
TODO
Designs:
https://www.figma.com/file/jdMk5ssz2Av7KFfEaeK7de/Events?node-id=1521%3A15155&mode=dev
Current State