Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events: Use a showcase like approach for the events list/archive #1124
Events: Use a showcase like approach for the events list/archive #1124
Changes from 1 commit
44371c8
1a5adca
a43b837
d568afe
cf3a3f4
12b7c06
29f8205
c73ed57
9cc0b23
5b413d4
8404ff7
5819e91
e636d34
3e7d9c2
9662871
1ee70b1
76c027c
55b279c
55b4e41
7b10fbb
d3db670
c26787d
855fa57
0889f6f
303e77f
0de639a
b0c2278
9908d41
8796cbb
47fdebd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cutting the list off at 10, but we only want that for the homepage. Maybe the block should accept a
limit
attribute that defaults to50
or something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good idea. I was thinking about the grouping as well. Should we pass in a
groupyByMonth
property? Feels too specific.Alternatively, we can pass a "heading" property to this list block and create a wrapper block where we use the query results to loop and output multiple instances of the event list block. I'll look at that today.