Events 2023: Update local nav #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be a yes. Let's just merge it. I don't know why this would work differently. It's a wp.org property now. |
Make sticky and change mobile nav to black on white
adamwoodnz
force-pushed
the
update/local-nav-style
branch
from
120b611 to
46db72e
Compare
Agreed, this is the default for the component now. |
I'm not authorized to merge. |
I sent you an invite 👍🏻 |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the local nav is not sticky like on other sites (Showcase, Main, Developer). This PR fixes that and also updates the background of the mobile navigation to be black text on white background to match the rest of the UI.
Note: This is pending an answer from design.
Screenshots