Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble with the PDF generation functionality, and it looks like the
wkhtmltopdf
library wasn't loaded correctly. I'm not entirely sure updating this in the docker is correct (or if this was just an issue with my install), but this fixed the issues for me.When generating an invoice, I hit this error:
So this PR updates the docker setup to install the Debian 9 (stretch) version of
wkhtmltopdf
, which does not rely on linked resources (see the note about generic builds). I also updated the nginx configuration to serve .pdf files from the uploads directory.Note: I'm not sure that Debian 9 is actually the correct OS- it's what I've got, but it looks like the
php:7.2-fpm
base should be installing Debian 10.To test
(not requesting reviews since I haven't take the time to test a clean install yet, but anyone should feel free to comment 🙂 )