Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event flag error #362

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix event flag error #362

merged 1 commit into from
Oct 2, 2024

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Sep 24, 2024

Fixes #359
The event flag that tells if a user is attending or hosting on the my events page and it had a bug which this PR fixes. In this PR we ensure that for an event that has ended;
if user is a host, we display Hosted
if user is only an attendee, we display Attended

If the event has not ended;
if user is a host, we display Hosting
if user is only an attendee, we display Attending

Before
Screenshot 2024-09-24 at 23 51 14

After
Screenshot 2024-09-24 at 23 47 13

@trymebytes trymebytes marked this pull request as ready for review September 24, 2024 22:55
@trymebytes trymebytes requested a review from akirk September 24, 2024 22:55
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@trymebytes trymebytes merged commit 10c4f60 into trunk Oct 2, 2024
3 checks passed
@trymebytes trymebytes deleted the fix-flag branch October 2, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event List shows "Attending" when an event is over
2 participants