Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor attendance mode #369

Merged
merged 17 commits into from
Nov 19, 2024
Merged

Contributor attendance mode #369

merged 17 commits into from
Nov 19, 2024

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Oct 10, 2024

Fixes #346 In this PR, we add the video icon to the user avatar to identify remote attendees and contributors.

Before
Screenshot 2024-10-14 at 15 46 45

After
Screenshot 2024-10-14 at 15 47 01

@trymebytes trymebytes marked this pull request as ready for review October 14, 2024 15:13
@trymebytes trymebytes requested a review from akirk October 15, 2024 11:49
@amieiro amieiro self-requested a review November 5, 2024 08:00
amieiro
amieiro previously requested changes Nov 5, 2024
Copy link
Collaborator

@amieiro amieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested at WordCamp Granada (hybrid event) and at WordCamp Kerala (remote event) and the icons are not properly aligned.

What do you think to add these CSS to a CSS file instead of adding them inline?

image

image

@trymebytes trymebytes force-pushed the contributor-attendance-mode branch from e01b7f1 to 9cea88b Compare November 13, 2024 15:25
@trymebytes
Copy link
Collaborator Author

Here is the updated view;

image

@trymebytes trymebytes requested a review from amieiro November 13, 2024 15:45
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well!

@trymebytes trymebytes dismissed amieiro’s stale review November 19, 2024 13:44

Fixed, thank you!

@trymebytes trymebytes merged commit 037426f into trunk Nov 19, 2024
3 checks passed
@trymebytes trymebytes deleted the contributor-attendance-mode branch November 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add attendance mode to attendee list
3 participants