Add video icon to flag remote events #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amieiro
requested changes
Nov 5, 2024
| <?php | ||
| if ( 'remote' === $event->attendance_mode() ) { | ||
| // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | ||
| echo do_blocks( sprintf( '<!-- wp:wporg-translate-events-2024/remote-attendance-icon %s /-->', wp_json_encode( array( 'inline_css' => 'float:left; margin-right:3px' ) ) ) ); |
There was a problem hiding this comment.
I think we should add some margin in the top. You can see the 5px in the row (1) vs the current margin in the row (2).
Suggested change
| echo do_blocks( sprintf( '<!-- wp:wporg-translate-events-2024/remote-attendance-icon %s /-->', wp_json_encode( array( 'inline_css' => 'float:left; margin-right:3px' ) ) ) ); | |
| echo do_blocks( sprintf( '<!-- wp:wporg-translate-events-2024/remote-attendance-icon %s /-->', wp_json_encode( array( 'inline_css' => 'float:left; margin:5px 3px 0 0' ) ) ) ); |
One question about adding the inline CSS: what do you thing about extracting these CSS to a CSS file instead of adding them inline?
There was a problem hiding this comment.
Resolved in #377
trymebytes
force-pushed
the
contributor-attendance-mode
branch
from
e01b7f1 to
9cea88b
Compare
|
Resolved in #377 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335 To allow easy identification of remote-only events.
Before
After
