Lint routes and templates #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
reviewed
Feb 15, 2024
akirk
reviewed
Feb 15, 2024
akirk
reviewed
Feb 15, 2024
|
|
||
| // TODO: Remove this file once there are actual tests. | ||
|
|
||
| /** |
There was a problem hiding this comment.
Should this be this?
Suggested change
| /** | |
| /* |
There was a problem hiding this comment.
The coding standards don't allow it somehow. It's viewed as the class comment so must start with /**. This will be removed soon once we add tests.
amieiro
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PHP linting PR. I would suggest reviewing commit by commit, as each commit should be self-explanatory. I've made small refactors where appropriate.