Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the default minimum PHP version shortcode to "7.2" #481

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jul 18, 2024

WordPress 6.6 changed the minimum supported PHP version to PHP 7.2.
The requirements page continues to claim 7.0+:
WordPress also works with PHP 7.0+ and MySQL 5.5.5+.
The compatibility page notes that WordPress 6.6 dropped support for versions 7.0 and 7.1.

Fixes https://meta.trac.wordpress.org/ticket/7723

Props pkevan

The latest WordPress 6.6 release dropped support for PHP 7.0 and 7.1,
making 7.2 the minimum supported version.

See the announcement post:

https://make.wordpress.org/core/2024/04/08/dropping-support-for-php-7-1/
@sirreal
Copy link
Member Author

sirreal commented Jul 18, 2024

I've tried running this locally, but I don't see the shortcode value updated 😕

It looks like this change should be sufficient, I'm not sure what the issue is:

<!-- wp:paragraph -->
<p><?php
/* translators: [minimum_php] is a shortcode and should not be translated. */
_e( 'Note: If you are in a legacy environment where you only have older PHP or MySQL versions, WordPress also works with PHP [minimum_php]+ and MySQL 5.5.5+. However, these versions have reached their official End Of Life and <strong>may expose your site to security vulnerabilities</strong>.', 'wporg' );
?></p>
<!-- /wp:paragraph -->

@sirreal sirreal marked this pull request as ready for review July 18, 2024 11:57
@Clorith
Copy link
Member

Clorith commented Jul 18, 2024

The change noted here will modify the default value if the MINIMUM_PHP constant is not defined, if not then that constant needs to be modified, this is not declared in the theme, but rather in the Serverhappy config, found at https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php (this means that any patch for this particular file will need ot be written for trac, and not GitHub :) )

@sirreal
Copy link
Member Author

sirreal commented Jul 18, 2024

Thanks for linking to that! I've attached a patch to the ticket.

@javiercasares
Copy link

I don't know if it can be possible, but it's not really 7.2, but 7.2.24 or 7.2.24 (depends on the source) the minimum version…

https://make.wordpress.org/core/2024/04/08/dropping-support-for-php-7-1/
https://make.wordpress.org/hosting/2024/07/10/wordpress-6-6-server-compatibility/

@dd32 dd32 merged commit 16a3699 into WordPress:trunk Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants