Content updates from Page Editor #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@StevenDufresne I think you made this change, can you add some context to this PR? |
|
Yep, follow-up to: #494 (comment) |
github-actions
bot
force-pushed
the
automated/content-update
branch
2 times, most recently
from
cc45996
to
276e772
Compare
ryelle
reviewed
Sep 24, 2024
| <li class="has-white-color has-text-color has-link-color"><?php _e( 'Connect with WordPress across social media platforms: <a href="https://www.tumblr.com/wordpress">Tumblr</a>, <a href="https://x.com/wordpress">X/Twitter</a>, <a href="https://www.facebook.com/WordPress/">Facebook</a>, <a href="https://www.instagram.com/wordpress/">Instagram</a>, <a href="https://www.linkedin.com/company/wordpress/">Linkedin</a>, and <a href="https://www.youtube.com/wordpress">YouTube</a>.', 'wporg' ); ?></li> | ||
| <li class="has-white-color has-text-color has-link-color"><?php _e( 'Connect with WordPress across social media platforms: <a href="https://www.tumblr.com/wordpress">Tumblr</a>, <a href="https://x.com/wordpress">X/Twitter</a>, <a href="https://www.facebook.com/WordPress/">Facebook</a>, <a href="https://www.instagram.com/wordpress/">Instagram</a>, <a href="https://www.linkedin.com/company/wordpress/">Linkedin</a>, and <a href="https://www.youtube.com/wordpress">YouTube</a>.', 'wporg' ); ?></li> |
There was a problem hiding this comment.
@ndiego Was replacing these spaces with intentional? It creates a string change so I just want to check.
There was a problem hiding this comment.
No it wasn't 🤦♂️ That must have been done automatically. I only intended to add the padding.
There was a problem hiding this comment.
Oh strange, it's still a string change— I think those spaces were already using the non-breaking space, just not encoded. In any case, I've updated it to use regular spaces which fixes some awkward wrapping on mid-sized screens.
github-actions
bot
force-pushed
the
automated/content-update
branch
2 times, most recently
from
7ddc346
to
b22d243
Compare
|
For clarity, these are the changes in this PR:
|
github-actions
bot
force-pushed
the
automated/content-update
branch
from
b22d243
to
a707a9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pages have been updated in the Page Editor.
Screenshots: https://github.com/WordPress/wporg-main-2022/actions/runs/11018010318/artifacts/1972707741
Please review, merge, and deploy.