CP-1164 Update readme with zsh instructions for completions. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
@georgelesica-wf I tried this out and it worked for me! We should still look into #103 though, because you have to have a copy of dart_dev installed in order to source the completions script and that could lead to completion mismatches if the version installed in a project differs from the version sourced by your bash/zsh profile. +1 |
|
@evanweible-wf agreed, that looks nice. Maybe I'll take a look at that on Monday. In the meantime, I just didn't want all you Zsh users to be left out of all the fun ;-) |
|
+1 |
jayudey-wf
changed the title
|
QA +1 doc change only (evan tested the instructions as well) Merging into master |
jayudey-wf
added a commit
that referenced
this pull request
Dec 8, 2015
CP-1164 Update readme with zsh instructions for completions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Completion only works on Bash but some people like Zsh!
Solution
Add instructions for making the completions work with Zsh.
FYI
@evanweible-wf - you might want to test this to be sure it works in real life, I tested it on my local Zsh from Homebrew, but since I don't use Zsh normally I don't actually have a
.zshrcand such and I just punched everything in at a command line.