-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a custom time provider in TracerProviderBase #158
Allow a custom time provider in TracerProviderBase #158
Conversation
This mirrors the capability in WebTracerProvider.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
This is my first pull request! |
Remove redundant @Protected annotation on private member. Co-authored-by: Blake Roberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
This is my first proposal / use of github for code changes. Please let me know if there's something more I should be doing. :)
QA +1 CI is sufficient |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
This mirrors the capability in WebTracerProvider.
Which problem is this PR solving?
I have an opentelemetry implementation using the Dart library (thanks!). I've noticed clock skew between my web/flutter client and dart backend. I have clock synchronisation in the client. This PR allows me to provide my own TimeProvider which exposes synchronised time time, nicely aligning traces between app and server.
The WebTracerProvider constructor does allow providing a TimeProvider, but cannot be used in non-web platforms.
Fixes # 99 which is expanded in opentelemetry-js 1652
Short description of the change
Simply provide a named parameter to override the default TimeProvider in the TracerProviderBase, as is done in the WebTracerProvider.
How Has This Been Tested?
I have added a unit test demonstrating a custom time provider.
Checklist: