Skip to content

Commit

Permalink
Merge pull request #923 from Workiva/investigate_ci
Browse files Browse the repository at this point in the history
Investigating CI failures
  • Loading branch information
rmconsole5-wk authored May 29, 2024
2 parents 35d5025 + c3ab958 commit 1edc7b2
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 17 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/dart_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
fail-fast: false
matrix:
# Can't run on `dev` (Dart 3) until we're fully null-safe.
sdk: [ 2.18.7, 2.19.6 ]
sdk: [ 2.19.6 ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v0.2
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
with:
sdk: ${{ matrix.sdk }}

Expand All @@ -39,7 +39,7 @@ jobs:
- name: Verify formatting
run: dart run dart_dev format --check
# Only run on one sdk version in case there are conflicts
if: always() && matrix.sdk != '2.18.7' && steps.install.outcome == 'success'
if: always() && matrix.sdk != '2.19.6' && steps.install.outcome == 'success'

# Analyze before generated files are created to verify that component boilerplate analysis is "clean" without the need for building
- name: Analyze example source (pre-build)
Expand All @@ -59,12 +59,12 @@ jobs:

- name: Verify that generated files are up-to-date
run: |
if [ ${{ matrix.sdk }} = '2.18.7' ]; then
if [ ${{ matrix.sdk }} = '2.19.6' ]; then
git diff --exit-code
else
# Don't check these generated files for other SDKs, since they may generate differently
# due to different resolved dependencies.
git diff --exit-code -- ":(exclude)test/mockito.mocks.dart" ":(exclude)test/over_react/component_declaration/redux_component_test/test_reducer.g.dart"
git diff --exit-code -- ":(exclude)test/over_react/component_declaration/redux_component_test/test_reducer.g.dart"
fi
if: always() && steps.install.outcome == 'success' && steps.install.build == 'success'

Expand Down Expand Up @@ -98,14 +98,14 @@ jobs:
fail-fast: false
matrix:
# Can't run on `dev` (Dart 3) until we're fully null-safe.
sdk: [ 2.18.7, 2.19.6 ]
sdk: [ 2.19.6 ]
analyzer:
# We only have one version currently, but we'll leave this CI step in place
# for the next time we need to support multiple analyzer versions.
- ^5.1.0
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v0.2
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
with:
sdk: ${{ matrix.sdk }}

Expand Down Expand Up @@ -140,8 +140,8 @@ jobs:
# Can't run on `stable` (Dart 3) until we're fully null-safe.
sdk: [ 2.19.6 ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v0.2
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
with:
sdk: ${{ matrix.sdk }}

Expand Down
41 changes: 41 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Publish

on:
push:
tags:
- '[0-9]+.[0-9]+.[0-9]+'

permissions:
contents: write
id-token: write
pull-requests: write

jobs:
create-sbom-release-asset:
name: Create SBOM Release Asset
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Publish SBOM to Release Assets
uses: anchore/sbom-action@v0
with:
path: ./
format: cyclonedx-json

publish:
name: Publish to pub.dev
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
with:
sdk: 2.19.6

- name: Install dependencies
run: dart pub get

- name: Publish - dry run
run: dart pub publish --dry-run

- name: Publish
run: dart pub publish -f
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# OverReact Changelog
## 5.1.1 & 5.1.2
- Fixes to CI [#921] [#922]
- Add auto-publish to pub.dev

## 5.1.0
- [#910] / [#916] Add null safety migration / component authoring guides.
Expand Down
4 changes: 0 additions & 4 deletions build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ builders:
targets:
$default:
builders:
mockito:mockBuilder:
generate_for:
include:
- "test/mockito.dart"
over_react|_over_react_local_builder:
enabled: true
generate_for:
Expand Down
2 changes: 0 additions & 2 deletions dart_dependency_validator.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
exclude:
- app/**
- tools/**
ignore:
- mockito
allow_pins: true

0 comments on commit 1edc7b2

Please sign in to comment.