FED-3255 Allow analyzer 6.x #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| expect(TypeNameHelper(parseAndGetSingleWithType(''' | ||
| foo.SomeTypeName foo; | ||
| ''')).nameWithPrefix, 'foo.SomeTypeName'); | ||
| }); | ||
| }); | ||
|
|
||
| group('NameHelper', () { |
There was a problem hiding this comment.
This extension is exclusive to Identifier, and in analyzer 6 type names are no longer parsed as Identifier, so these cases needed to be updated
greglittlefield-wf
dismissed
robbecker-wf’s stale review
The base branch was changed.
|
QA+1 CI passes on all combinations. Validated that analyzer 5 and 6 are actually used and pass. |
robbecker-wf
approved these changes
Oct 18, 2024
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #958
Motivation
over_react currently allows analyzer 5.x, but not analyzer 6.x, which prevents newer versions of other packages from being pulled in.
We were previously blocked on supporting analyzer 6.x since it can only be used in Dart 3, but now we support Dart 3!
Changes
NamedType.name, which was removed in analyzer 6.0.0name2(the name without the prefix)importPrefix(just the prefix)Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: