Skip to content

Commit

Permalink
Make args optional to fix dart2js failures
Browse files Browse the repository at this point in the history
  • Loading branch information
greglittlefield-wf committed Oct 18, 2024
1 parent 7c4bed2 commit fc2deca
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/factory/common_factory_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ void _childKeyWarningTests(ReactComponentFactoryProxy factory,
consoleErrorMessages = [];

final originalConsoleError = context['console']['error'] as JsFunction;
context['console']['error'] = JsFunction.withThis((self, message, arg1, arg2, arg3) {
context['console']['error'] = JsFunction.withThis((self, [message, arg1, arg2, arg3]) {
originalConsoleError.apply([message], thisArg: self);

// Ignore unrelated messages
Expand Down
2 changes: 1 addition & 1 deletion test/lifecycle_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ main() {

consoleErrorMessages = [];
final originalConsoleError = context['console']['error'] as JsFunction;
context['console']['error'] = JsFunction.withThis((self, message) {
context['console']['error'] = JsFunction.withThis((self, [message, arg1, arg2, arg3]) {
originalConsoleError.apply([message], thisArg: self);

// Ignore unrelated warnings
Expand Down

0 comments on commit fc2deca

Please sign in to comment.