Only generate backwards-compatible output when necessary #52
+69
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todbachman-wf
previously approved these changes
Nov 7, 2024
|
The example tests are timing out on stable and beta because the |
evanweible-wf
force-pushed
the
smart-output-of-backwards-compat-file
branch
from
6ccd870
to
3e4e1be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3, we moved the output of the browser-aggregation test config from
test/dart_test.browser_aggregate.yamltodart_test.browser_aggregate.yaml(in the root). For backwards-compatibility, we continued to output to the deprecated location, too. Most consumers should already be including thedart_test.browser_aggregate.yamlin the root instead of the copy from thetest/directory, but if they aren't, it should be trivial to detect by readingdart_test.yamlwhere it would need to be included.This PR makes that change: when
test/dart_test.browser_aggregate.yamlis found indart_test.yaml, the builder will output that file. Otherwise, it will not, and only the rootdart_test.browser_aggregate.yamlwill be generated.