S192 : seq num fix #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschultink
commented
Feb 1, 2025
| @@ -85,7 +89,7 @@ private static RetryerBuilder baseRetryerBuilder() { | |||
| .retryIfExceptionOfType(ApiProxyException.class) | |||
| // don't think this is thrown by new datastore lib | |||
| // thrown by us if the task state is from the past | |||
| .retryIfExceptionOfType(ConcurrentModificationException.class) | |||
| .retryIfExceptionOfType(IllegalStateException.class) | |||
There was a problem hiding this comment.
changed this, bc I think it more accurate reflects what the situation is.
I don't think it's getting concurrently modified; I think the task is executing before txn is committed OR before txn outcome can be seen
eschultink
commented
Feb 1, 2025
| tx.commit(); | ||
| scheduleWorkerTask(settings, taskState, null); |
There was a problem hiding this comment.
this should help too; don't enqueue task until AFTER we've successfully committed.
We do have a risk that if enqueuing task fails, shard will just stall out, right? Nothing to recover it and ensure it eventually gets executed.
| @@ -183,21 +187,23 @@ private void scheduleControllerTask(ShardedJobRunId jobId, IncrementalTaskId tas | |||
| .param(TASK_ID_PARAM, taskId.toString()); | |||
| taskOptions.header("Host", settings.getTaskQueueTarget()); | |||
|
|
|||
| taskOptions.etaMillis(System.currentTimeMillis() + CONTROLLER_TASK_DELAY); | |||
There was a problem hiding this comment.
added some delay here, bc again we're inside a txn, but enqueuing in the middle of it rather than at the end.
jlorper
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Change implications