misc docs / terraform tweaks (#826)

* bump time in MSFT api call example * ignore some msft app listing changes * reactions in example from slack API * Update infra/modules/worklytics-connector-specs/main.tf Co-authored-by: aperez-worklytics <[email protected]> * syntax fix --------- Co-authored-by: aperez-worklytics <[email protected]>
Worklytics · Dec 4, 2024 · eacef4b · eacef4b
1 parent c35889c
commit eacef4b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/infra/modules/azuread-connection/main.tf b/infra/modules/azuread-connection/main.tf
@@ -53,6 +53,16 @@ resource "azuread_application" "connector" {
       }
     }
   }
+
+  lifecycle {
+    # see https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/resources/application#argument-reference
+    ignore_changes = [
+      # '(Optional) References application context information from a Service or Asset Management database.' --> have seen customers manage this outside our provided Terraform
+      service_management_reference,
+      # internal notes; have seen customers manage this outside our provided Terraform
+      notes
+    ]
+  }
 }
 
 output "connector" {

diff --git a/infra/modules/worklytics-connector-specs/main.tf b/infra/modules/worklytics-connector-specs/main.tf
@@ -276,7 +276,7 @@ locals {
       example_api_calls : [
         "/v1.0/users",
         "/v1.0/users/${var.example_msft_user_guid}/events",
-        "/v1.0/users/${var.example_msft_user_guid}/calendarView?startDateTime=2022-10-01T00:00:00Z&endDateTime=${time_static.deployment.id}",
+        "/v1.0/users/${var.example_msft_user_guid}/calendarView?startDateTime=${timeadd(time_static.deployment.id, "-4320h")}&endDateTime=${time_static.deployment.id}",
         "/v1.0/users/${var.example_msft_user_guid}/mailboxSettings",
         "/v1.0/groups",
         "/v1.0/groups/{group-id}/members"
@@ -902,7 +902,7 @@ EOT
         "/api/discovery.conversations.list?limit=10",
         "/api/discovery.conversations.info?team={WORKSPACE_ID}&channel={CHANNEL_ID}",
         "/api/discovery.conversations.recent?limit=10",
-        "/api/discovery.conversations.history?team={WORKSPACE_ID}&channel={CHANNEL_ID}&limit=10",
+        "/api/discovery.conversations.history?reactions=1&team={WORKSPACE_ID}&channel={CHANNEL_ID}&limit=10",
         "/api/discovery.users.list?limit=5",
       ]
       external_token_todo : <<EOT