Gh onprem connector #579
Merged
Gh onprem connector #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschultink
approved these changes
Nov 22, 2023
eschultink
added a commit
that referenced
this pull request
Nov 23, 2023
* update release refs to rc-v0.4.41 * release tooling (#566) * document release process * imls for tools * ensure example's main in good state before publish * deterministic rule serialization (#567) * deterministic serialization of Rules2 * add some comments on serialization * more documentation (#565) * improve main README * provide some more security documentation * Update docs/faq-security.md Co-authored-by: aperez-worklytics <[email protected]> * Update docs/aws/authentication-authorization.md Co-authored-by: aperez-worklytics <[email protected]> --------- Co-authored-by: aperez-worklytics <[email protected]> * Always return scope from source, if missing in rules * Remove IDE warning * Remove IDE warning (put back Java8 compatiblity) * Fix tests * improve jira/zoom docs (#569) * reformat Jira cloud docs * alignment * more alignment * add zoom screenshot * zoom docs alignment * jira note on needing a terminal * test config takes precedence over rules (#571) * fix java21 (#572) * matrix build for java 21 * lombok upgraded to support jdk 21 * upgrade version numbers to fix refs to v21 * try upgrade junit, mockito * fix build * revert mocks to subclasses as needed * try to fail back mockito behavior to keep java 11, 8 working * standard build to java 21 * fix java version check * upgrade apache commons lang3 * update workflows * update README * stronger java check, doc prereqs * strengthen prereq check * comment out 20, as can't fix it * stop caching mvn packages and see if works * fix indent * get rid of skipping processing of dependencies * add back clearing of mvn repo of our own artifacts, in case a problem * stop tests of 18,19,20 * recover more sensible workflows * fill h_4 pseudonym (v0.4 hash) in legacy case (#570) * fill h_4 with default pseudonyms * wip of fixing tests, migrating examples to non-legacy pseudonyms * revert dbx example to original * fix lots of examples * fix dbx example * fix more test cases * fix more test cases * fix rest of test cases * fix test case * rules cleanup (#575) * more comments on Endpoint * connector doc improvements * improve health check (#576) * add PSEUDONYMIZE_APP_IDS value to health check, if set * simplify version handling in health checks, improve tests * health check logs less verbose, as otherwise confuses people * unused variable in tests * revert version target * remove multi-line strings, to preserve java 11 source compatibility atm * fix test case * switch-up mockito version, try to downgrade in java8 case * disable java8 build * try to fix java tests across platforms * allow manual trigger of java8 workflow * Fixed unit tests. (#577) Co-authored-by: Erik Schultink <[email protected]> * Gh onprem connector (#579) * Allow customize github api host for supporting on prem versions * Updated readme * Fix broken link * Fix broken link * logic around optionals, to avoid creating hard dep on SOURCE * avoid ever having 'empty' scope, which is non-sensical; want null or explicit value --------- Co-authored-by: Erik Schultink <[email protected]> Co-authored-by: Erik Schultink <[email protected]> Co-authored-by: aperez-worklytics <[email protected]> Co-authored-by: Valentyn Ponomarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Features
Change implications
CHANGELOG.md? noterraform plan/applythat isn't obviously a no-op? noalpha, requires major version change no