env var only config #823
Merged
env var only config #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlorper
reviewed
Oct 10, 2024
| } | ||
| ) | ||
| @ParameterizedTest | ||
| public void remoteConfigVars(String paramName) { |
jlorper
requested changes
Oct 10, 2024
| @@ -61,6 +61,10 @@ public SecretManagerConfigService(@Assisted("projectId") @NonNull String project | |||
|
|
|||
| @Override | |||
| public void putConfigProperty(ConfigProperty property, String value) { | |||
| if (property.isEnvVarOnly()) { | |||
There was a problem hiding this comment.
Tip: I like preconditions for these kind of checks.
Preconditions.checkArgument(!property.isEnvVarOnly(), "Can't put env-only config property: " + property);
aperez-worklytics
approved these changes
Oct 14, 2024
jlorper
approved these changes
Oct 21, 2024
eschultink
added a commit
that referenced
this pull request
Dec 4, 2024
* a bunch of config property stuff * checks for env-var only config * fix missing test :facepalm * CR feedback to use preconditions to check args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Change implications
CHANGELOG.mdanything that will show up interraform plan/applythat isn'tobviously a no-op? if anyone is depending on overriding env vars with secrets/parameter store, this will break that
alpha, requires major versionchange