Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with integer FITS files with BLANK keywords #378

Merged
merged 6 commits into from
Dec 29, 2024

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Dec 29, 2024

Overview

It turns out that reproject has a bug in dealing with integer FITS images that have BLANK keywords. This affects the cutouts images processed by daschlab. This should be fixed upstream, but that might take a while, so in the meantime let's work around it.

We also refresh the API docs and add a script to help make sure they get updated regularly.

Checklist

  • Changed code has some test coverage (or justify why not)
  • Changes in functionality documented (or justify why not)

No test coverage, sorry :-(

@pkgw
Copy link
Contributor Author

pkgw commented Dec 29, 2024

Upstream bug report is astropy/reproject#475 .

@pkgw
Copy link
Contributor Author

pkgw commented Dec 29, 2024

Also adding multi-wcs support here since it turns out to be a small change.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.37%. Comparing base (f20f1f4) to head (00160f3).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pywwt/utils.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   56.40%   56.37%   -0.04%     
==========================================
  Files          25       25              
  Lines        2863     2870       +7     
==========================================
+ Hits         1615     1618       +3     
- Misses       1248     1252       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkgw pkgw merged commit cb1f55c into WorldWideTelescope:master Dec 29, 2024
4 of 5 checks passed
@pkgw pkgw deleted the blank-fits branch December 29, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant