-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vortex: improve HU mode-switch, keep-alive, handle brake errors #252
Conversation
95f1eba
to
36a90b7
Compare
OK; I will wait for GO before merge. |
Using updated FW (HU 0.2.5, brake 0.2.7) and provided .exe build seemed to fixed most of the problems:
Note:
In conclusion it seems that all the major bugs were fixed as reported in #219 by @ditisdirkdewit as well. Thanks! |
@cermatej Thanks for your feedback, that is good to hear!
The calibrated power value (in watts) comes directly from the brake, we don't do any post-processing on that (and we don't send any calibration commands either), so I don't think this is because of the patch. Maybe they have changed/improved the calibration algorithm in the newer firmware. The power from my Vortex (with the latest firmware, after calibrating with the head unit) is very close to my Garmin Vector 2 pedals. |
@WouterJD Both @cermatej and @ditisdirkdewit have tested this successfully and I have used it a bit more myself without any problems, so I think this can be merged. |
I see this can be merged into Master. |
@WouterJD I see. I will rebase to Raspberry_Release6. I don't expect any actual conflicts, probably just some comments/changelog so this should be easy hopefully. |
Thanks for the rebasing; I will merge as soon as available |
Several small improvements for Tacx Vortex:
wrong mode is detected (e.g. first command gets lost, HU was turned off and on again)
(head unit only turns off after 3 minutes)
i-Vortex is just the T2170 bundle, but older T1960/T1965 bundles should work just
as well
Windows binary: https://github.com/switchabl/FortiusANT/suites/2021188431/artifacts/40537444
Tested with my T2171 brake/T1962 HU, will try to get other Vortex users to test before merge.
Not sure if this helps with #219, still looking into that (could not reproduce with my Vortex).