Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported embedded API from master. #28

Open
wants to merge 1 commit into
base: sustaining/3.5.x
Choose a base branch
from

Conversation

siepkes
Copy link
Member

@siepkes siepkes commented Feb 23, 2019

Adds new classes to hold parameters of operations on the directory server: ConnectionParameters, ImportParameters, RebuildIndexParameters, ReplicationParameters, SetupParameters, UpgradeParameters.

Adds new classes to hold parameters of operations on the directory
server: ConnectionParameters, ImportParameters, RebuildIndexParameters,
ReplicationParameters, SetupParameters, UpgradeParameters.
@Kortanul
Copy link
Member

@siepkes Are you sure this is the target branch you wanted for this operation? Or is this PR supposed to target master after master is changed to be based off of 3.5 instead of 4.x?

I ask because:

  • I was thinking that we weren't back-porting features from master to 3.5; I thought we were going to create a new 4.x from 3.5 then port features from the old 4.x to that new 4.x codebase.
  • CI failed because the versions did not match (parent POM was missing).

@siepkes
Copy link
Member Author

siepkes commented Apr 18, 2019

@Kortanul The branch is indeed not the right one. I made the PR against this branch because it needed to be on something 3.5-ish and not master. I just put it here so people could build a DS required for an AM 14 build. I should have made that clearer, sorry about that.

So this needs to go in the new 4.x branch as you said: Create a new 4.x from 3.5 then port features from the old 4.x to that new 4.x codebase.

@pavelhoral pavelhoral added the version:3.x Issues that apply to Wren:DS 3.x. label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:3.x Issues that apply to Wren:DS 3.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants