Added multiple options to webemulator. #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the webemulator is able to handle the following options: * ram = amount of memory in steps of 8K (8-2048) * cpu = c816 or c02 * mhz = speed in MHz, minimum 1 * keymap = same list of keymaps supported as normal emualtor * longpwron = Boot emulator into RAM diagnostics * widescreen = enable widescreen if true * capture = capture keyboard and mouse if true All of the above options are available on the address/url or in the manifest file. On the address line longpwron, widescreen & capture do not need values to be enabled. In the manifest file, they must be set to true. Options in manifest file take precedens over options on address line.
This should address this issue: X16Community#287
mooinglemur
approved these changes
Oct 11, 2024
mooinglemur
reviewed
Oct 11, 2024
| emuArguments.push('-c816'); | ||
| } |
There was a problem hiding this comment.
Just one point here, it's possible that 816 will become the default later, so perhaps this should check for c02 in cpu_val and if it is set, add -c02 to the emu args.
This will have to be done in a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the webemulator is able to handle the following options:
Options in manifest file take precedens over options on address line.
On the address line the options would look something like this:
?manifest=myprog.prg&ram=2048&cpu=c816&mhz=10&keymap=da&widescreen&capture&longpwron
The options in the manifest file would look like this:
"ram": "2048",
"cpu": "c816",
"mhz": "10",
"keymap": "da",
"widescreen": true,
"capture": true,
"longpwron": false,