Skip to content

Commit

Permalink
Reverts cache_docker_images.sh
Browse files Browse the repository at this point in the history
  • Loading branch information
XComp committed Dec 21, 2023
1 parent 1fc161f commit 61be65c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/template.flink-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ jobs:

- name: "Load Docker images if not present in cache, yet"
if: ${{ !cancelled() && !steps.docker-cache.cache.hit }}
run: ./tools/azure-pipelines/cache_docker_images.sh -f ${{ env.DOCKER_IMAGES_CACHE_FOLDER }} load
run: ./tools/azure-pipelines/cache_docker_images.sh load

- name: "Test - ${{ matrix.module }}"
id: test-run
Expand Down Expand Up @@ -245,7 +245,7 @@ jobs:

- name: "Save Docker images to cache"
if: ${{ !cancelled() && (failure() || !steps.docker-cache.cache.hit) }}
run: ./tools/azure-pipelines/cache_docker_images.sh -f ${{ env.DOCKER_IMAGES_CACHE_FOLDER }} save
run: ./tools/azure-pipelines/cache_docker_images.sh save

e2e-prereq-check:
name: "Check: Code modified"
Expand Down Expand Up @@ -360,7 +360,7 @@ jobs:

- name: "Load Docker images if not present in Cache, yet"
if: ${{ !cancelled() && !steps.docker-cache.cache.hit }}
run: ./tools/azure-pipelines/cache_docker_images.sh -f ${{ env.DOCKER_IMAGES_CACHE_FOLDER }} load
run: ./tools/azure-pipelines/cache_docker_images.sh load

- name: "Build Flink"
run: ${{ inputs.environment }} ./tools/ci/validate.sh "install -DskipTests -Dfast $PROFILE -Pskip-webui-build"
Expand Down Expand Up @@ -388,4 +388,4 @@ jobs:

- name: "Save Docker images to Cache"
if: ${{ !cancelled() && (failure() || !steps.docker-cache.cache.hit) }}
run: ./tools/azure-pipelines/cache_docker_images.sh -f ${{ env.DOCKER_IMAGES_CACHE_FOLDER }} save
run: ./tools/azure-pipelines/cache_docker_images.sh save
8 changes: 0 additions & 8 deletions tools/azure-pipelines/cache_docker_images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@
# includes testcontainer images, kafka, elasticearch, etc.
#

while getopts "f:" o; do
case "${o}" in
f)
DOCKER_IMAGES_CACHE_FOLDER=${OPTARG};;
esac
done
shift $((OPTIND-1))

if [ -z "${DOCKER_IMAGES_CACHE_FOLDER:-}" ]
then
echo "\$DOCKER_IMAGES_CACHE_FOLDER must be set to cache the testing docker images. Exiting"
Expand Down

0 comments on commit 61be65c

Please sign in to comment.