-
Notifications
You must be signed in to change notification settings - Fork 55
Deduplication
sozud edited this page Sep 24, 2024
·
1 revision
SOTN has a huge number of duplicates. We want to get these factored out to make the codebase more usable.
This PR is a good example of the process when data is not involved https://github.com/Xeeynamo/sotn-decomp/pull/1200/files
- Add CheckColliderOffsets to the symbols.txt for each stage you want to dedupe. The address will be different for each overlay.
- Factor out the function into a header.
-
#include
the header in each file.
This is similar to the previous case but all data needs to be given names and added to symbols.txt as well. This PR is an example: https://github.com/Xeeynamo/sotn-decomp/pull/459/files
Note how some of the stages required PfnEntityUpdates to be renamed.