Fix (groupwise): correct log, groupdim, and scale computation #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
changed the title
14 tasks
i-colbert
approved these changes
Oct 28, 2024
Giuseppe5
force-pushed
the
fix_log_dim
branch
from
8c2454d
to
3ae82a4
Compare
Giuseppe5
requested review from
nickfraser
and removed request for
nickfraser
Giuseppe5
requested review from
nickfraser
and removed request for
nickfraser
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Fix an error with groupwise dimension, in case group_dim is set to -1
Fix an error in the computation of the scale when the scale is dynamic and power of 2
Testing Summary
Test is added in a separate PR
Risk Highlight
Checklist
devbranch.