Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add contributing guidelines #1075

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Feat: add contributing guidelines #1075

merged 2 commits into from
Oct 27, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Oct 25, 2024 •
edited
Loading

Reason for this PR

Contributing Guidelines

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

Thanks @auphelia and FINN for the inspiration.

nickfraser
nickfraser approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nickfraser
nickfraser reviewed Oct 25, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
nickfraser
nickfraser reviewed Oct 25, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Giuseppe5 Giuseppe5 merged commit 1dfed96 into Xilinx:dev Oct 27, 2024
22 of 23 checks passed
@Giuseppe5 Giuseppe5 deleted the contributing branch October 27, 2024 10:45
Giuseppe5 added a commit to Giuseppe5/brevitas that referenced this pull request Oct 29, 2024
@Giuseppe5
Feat: add contributing guidelines (Xilinx#1075)
b7de5b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser nickfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser