Fix: correct output scale compute #1077
Open
+24
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
There is a bug when computing output scale factor, when the input scale is quantized per-row and the weights are quantized per channel
Changes Made in this PR
Resolves the issue by skipping scale factor computation in this case. This means that we cannot have a properly formed quant tensor with this quantization strategy.
In theory, if I am not hallucinating, the math would results in a per-element scale factor, but we need to decide whether it's worth keeping track of this since any operation with such QuantTensor would results in dequantize.
Testing Summary
None
Risk Highlight
NA
Checklist
dev
branch.