Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (examples/generative): Fixed argument order for quantize_model #1084

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix (examples/generative): Fixed argument order for quantize_model #1084

merged 1 commit into from
Nov 1, 2024

Conversation

nickfraser
Copy link
Collaborator

@nickfraser nickfraser commented Nov 1, 2024 •
edited
Loading

Bugfix for quantize_model function in examples/generative. Bug affects optimum-amd integration.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@nickfraser nickfraser added bug Something isn't working examples Anything related to examples labels Nov 1, 2024
@nickfraser nickfraser merged commit 52e0059 into Xilinx:dev Nov 1, 2024
373 of 374 checks passed
@nickfraser nickfraser deleted the fix/quantize_model branch November 1, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giuseppe5 Giuseppe5 Awaiting requested review from Giuseppe5

Assignees
No one assigned
Labels
bug Something isn't working examples Anything related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickfraser