Disable region simplification in --aie-substitute-shim-dma-allocations
pass
#1755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern rewriter in this pass previously also performed region simplification, which caused an assertion error if the MLIR contained blocks with input arguments, such as generated by:
This fixes that issue. I don't fully understand why the issue exists with region simplification, but the point of this pass is not to simplify regions anyways, so it is fine to disable.