-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Enable init values for Object FIFO #1813
base: main
Are you sure you want to change the base?
Conversation
…st lock init values.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e DMAs from objectfifo repeatCount.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… to see if I can see error in CI
…u-xrt/objectfifo_repeat); delete unused cmake files
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
of_in = object_fifo("in", ShimTile, MemTile, 1, tensor_ty) | ||
of_out = object_fifo( | ||
"out", | ||
MemTile, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[black] reported by reviewdog 🐶
MemTile, | |
MemTile, |
MemTile = tile(col, 1) | ||
|
||
# AIE-array data movement with object fifos | ||
#of_in = object_fifo("in", ShimTile, MemTile, 1, tensor_ty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[black] reported by reviewdog 🐶
#of_in = object_fifo("in", ShimTile, MemTile, 1, tensor_ty) | |
# of_in = object_fifo("in", ShimTile, MemTile, 1, tensor_ty) |
], | ||
) | ||
of_out.set_repeat_count(memtile_repeat_count + 1) | ||
#object_fifo_link(of_in, of_out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[black] reported by reviewdog 🐶
#object_fifo_link(of_in, of_out) | |
# object_fifo_link(of_in, of_out) |
# To/from AIE-array data movement | ||
@runtime_sequence(tensor_ty, tensor_ty, tensor_out_ty) | ||
def sequence(A, B, C): | ||
#npu_dma_memcpy_nd(metadata=of_in, bd_id=1, mem=A, sizes=[1, 1, 1, N]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[black] reported by reviewdog 🐶
#npu_dma_memcpy_nd(metadata=of_in, bd_id=1, mem=A, sizes=[1, 1, 1, N]) | |
# npu_dma_memcpy_nd(metadata=of_in, bd_id=1, mem=A, sizes=[1, 1, 1, N]) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR builds on top of #1801 to enable objectfifos to take as input an array of initial values.
Specifically:
AIE_LockOps
with init values such that the initialized objects will not be overwritten before they are communicated to the consumer(s).