-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully open-source AIE flow #1900
Conversation
Coverage ReportCreated: 2024-11-01 20:39Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you improve the PR description (which will end up as the eventual commit message for the eternity) about why we need this new API?
message("Installing aie_api includes from ${SRCPATH} in ${BUILDPATH}") | ||
|
||
# copy header files into build area | ||
install(DIRECTORY ${SRCPATH}/ DESTINATION ${BUILDPATH}/aie_api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious about all these trailing /
in the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy the entire contents of the directory in cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. You mean that without a /
it would only create an empty directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A trailing slash will leave the last component empty and install the contents of the input directory to the destination.
https://cmake.org/cmake/help/book/mastering-cmake/chapter/Install.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. With CMake I learn all my life long!
Actually this is the equivalent of using /.
in as with normal Unix copy-related commands.
Changed the description and added a couple lines. We use this API in the single core code. It was previously distributed with Vitis. Now that this is open sourced and we can use Peano. We no longer have to depend on Vitis. |
Co-authored-by: Ronan Keryell <[email protected]>
@@ -11,3 +11,6 @@ | |||
[submodule "third_party/bootgen"] | |||
path = third_party/bootgen | |||
url = https://github.com/Xilinx/bootgen.git | |||
[submodule "third_party/aie_api"] | |||
path = third_party/aie_api | |||
url = https://github.com/jgmelber/aie_api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I have a fork that comments out an include to adf.h. A follow on will remove any defines to __AIENGINE__
, that will gate the include. We use the deprecated convention that flag defines something about the version of the AIE version and redundantly define the correct __AIEARCH__
.
Use open source aie_api
No longer rely on Vitis for any components to compile for AIE
Add aie_api as a submodule
Install aie_api with build
Use aie_api from install for Peano programming examples and programming guide